rdblue commented on code in PR #41:
URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429228120
##########
pyiceberg/manifest.py:
##########
@@ -897,9 +902,11 @@ def prepare_manifest(self, manifest_file: ManifestFile) ->
ManifestFile:
class ManifestListWriterV2(ManifestListWriter):
_commit_snapshot_id: int
- _sequence_number: int
+ _sequence_number: Optional[int]
Review Comment:
I think this is required for manifest list. This is always known when we
write the manifest list because manifest lists are written for every commit
attempt (after the sequence number has been updated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
