rdblue commented on code in PR #41:
URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429229166
##########
pyiceberg/manifest.py:
##########
@@ -920,9 +927,9 @@ def prepare_manifest(self, manifest_file: ManifestFile) ->
ManifestFile:
# To validate this, check that the snapshot id matches the current
commit
if self._commit_snapshot_id !=
wrapped_manifest_file.added_snapshot_id:
raise ValueError(
- f"Found unassigned sequence number for a manifest from
snapshot: {wrapped_manifest_file.added_snapshot_id}"
+ f"Found unassigned sequence number for a manifest from
snapshot: {self._commit_snapshot_id} !=
{wrapped_manifest_file.added_snapshot_id}"
)
- wrapped_manifest_file.sequence_number = self._sequence_number
+ wrapped_manifest_file.sequence_number = self._sequence_number or
INITIAL_SEQUENCE_NUMBER
Review Comment:
I don't think this is correct because the sequence number should always be
passed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
