nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432327788
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataSourceOptions.java:
##########
@@ -297,7 +299,7 @@ public void testIncrementalScanOptions() throws IOException
{
.orderBy("id")
.as(Encoders.bean(SimpleRecord.class))
.collectAsList();
- Assert.assertEquals("Records should match", expectedRecords.subList(1, 4),
result);
+ assertThat(expectedRecords.subList(1, 4)).as("Records should
match").isEqualTo(result);
Review Comment:
this should be the other way around: `expectedRecords.subList(1, 4)` should
go into `isEqualTo()` as that's what's being expected.
It looks like the assertions are the other way around in a bunch of places.
Could you please fix those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
