nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432340253
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReadProjection.java:
##########
@@ -110,7 +110,7 @@ public static void stopSpark() {
@Override
protected Record writeAndRead(String desc, Schema writeSchema, Schema
readSchema, Record record)
throws IOException {
- File parent = temp.newFolder(desc);
+ File parent = temp.resolve(desc).toFile();
Review Comment:
given that you're adjusting this file, shouldn't this also be updated to use
JUnit5? There is `@BeforeClass` / `@AfterClass` usage. For parameterizing the
test you can use the annotations introduced by
https://github.com/apache/iceberg/pull/9161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
