nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432728000
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataSourceOptions.java:
##########
@@ -407,13 +409,13 @@ public void testExtraSnapshotMetadata() throws
IOException {
Table table = tables.load(tableLocation);
-
Assert.assertTrue(table.currentSnapshot().summary().get("extra-key").equals("someValue"));
-
Assert.assertTrue(table.currentSnapshot().summary().get("another-key").equals("anotherValue"));
+
assertThat(table.currentSnapshot().summary().get("extra-key")).isEqualTo("someValue");
Review Comment:
in such cases it's usually better to do something like
```
assertThat(table.currentSnapshot().summary().containsEntry("extra-key",
"someValue).containsEntry("another-key", "anotherValue")
```
because if the assertion ever fails, the full map content will be printed,
which makes debugging much easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
