chinmay-bhat commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432413077
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestBaseReader.java:
##########
@@ -47,14 +49,13 @@
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.spark.data.RandomData;
import org.apache.iceberg.types.Types;
-import org.junit.Assert;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
public class TestBaseReader {
- @Rule public TemporaryFolder temp = new TemporaryFolder();
+ @TempDir
+ public Path temp;
Review Comment:
I'm now getting build errors on private access.
Example:
```
error: temp has private access in TestIcebergSourceTablesBase
this.tableDir = temp.toFile();
```
In [this
PR](https://github.com/apache/iceberg/pull/9129#discussion_r1403012159), you
mentioned using `protected` instead of `public`. Can I do that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
