rdblue commented on code in PR #9340:
URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435206166
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident,
Schema schema) {
public Catalog icebergCatalog() {
return icebergCatalog;
}
+
+ @Override
+ public Identifier[] listViews(String... namespace) {
+ if (null != asViewCatalog) {
+ return asViewCatalog.listViews(Namespace.of(namespace)).stream()
+ .map(ident -> Identifier.of(ident.namespace().levels(),
ident.name()))
+ .toArray(Identifier[]::new);
+ }
+
+ return new Identifier[0];
+ }
+
+ @Override
+ public View loadView(Identifier ident) throws NoSuchViewException {
+ if (null != asViewCatalog) {
+ try {
+ org.apache.iceberg.view.View view =
asViewCatalog.loadView(buildIdentifier(ident));
+ return new SparkView(catalogName, view);
+ } catch (org.apache.iceberg.exceptions.NoSuchViewException e) {
+ throw new NoSuchViewException(ident);
+ }
+ }
+
+ throw new NoSuchViewException(ident);
+ }
+
+ @Override
+ public View createView(
+ Identifier ident,
+ String sql,
+ String currentCatalog,
+ String[] currentNamespace,
+ StructType schema,
+ String[] queryColumnNames,
+ String[] columnAliases,
+ String[] columnComments,
+ Map<String, String> properties)
+ throws ViewAlreadyExistsException, NoSuchNamespaceException {
+ if (null != asViewCatalog) {
+ Schema icebergSchema = SparkSchemaUtil.convert(schema);
+
+ try {
+ org.apache.iceberg.view.View view =
+ asViewCatalog
+ .buildView(buildIdentifier(ident))
+ .withDefaultCatalog(currentCatalog)
+ .withDefaultNamespace(Namespace.of(currentNamespace))
+ .withQuery("spark", sql)
+ .withSchema(icebergSchema)
+ .withLocation(properties.get("location"))
+ .withProperties(Spark3Util.rebuildCreateProperties(properties))
+ .create();
+ return new SparkView(catalogName, view);
+ } catch (org.apache.iceberg.exceptions.NoSuchNamespaceException e) {
+ throw new NoSuchNamespaceException(currentNamespace);
+ } catch (AlreadyExistsException e) {
+ throw new ViewAlreadyExistsException(ident);
+ }
+ }
+
+ throw new UnsupportedOperationException(
+ "Creating view is not supported by catalog: " + catalogName);
+ }
+
+ @Override
+ public View alterView(Identifier ident, ViewChange... changes)
+ throws NoSuchViewException, IllegalArgumentException {
+ if (null != asViewCatalog) {
+ try {
+ org.apache.iceberg.view.View view =
asViewCatalog.loadView(buildIdentifier(ident));
+ UpdateViewProperties updateViewProperties = view.updateProperties();
+
+ for (ViewChange change : changes) {
+ if (change instanceof ViewChange.SetProperty) {
+ ViewChange.SetProperty property = (ViewChange.SetProperty) change;
+ updateViewProperties.set(property.property(), property.value());
+ } else if (change instanceof ViewChange.RemoveProperty) {
+ ViewChange.RemoveProperty remove = (ViewChange.RemoveProperty)
change;
+ updateViewProperties.remove(remove.property());
+ }
+ }
+
+ updateViewProperties.commit();
+
+ return new SparkView(catalogName, view);
+ } catch (org.apache.iceberg.exceptions.NoSuchViewException e) {
+ throw new NoSuchViewException(ident);
+ }
+ }
+
+ throw new UnsupportedOperationException(
+ "Altering view is not supported by catalog: " + catalogName);
Review Comment:
Nit: Should be `Altering a view` or `Altering views`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
