nastra commented on code in PR #9340:
URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435218641
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident,
Schema schema) {
public Catalog icebergCatalog() {
return icebergCatalog;
}
+
+ @Override
+ public Identifier[] listViews(String... namespace) {
+ if (null != asViewCatalog) {
+ return asViewCatalog.listViews(Namespace.of(namespace)).stream()
+ .map(ident -> Identifier.of(ident.namespace().levels(),
ident.name()))
+ .toArray(Identifier[]::new);
+ }
+
+ return new Identifier[0];
+ }
+
+ @Override
+ public View loadView(Identifier ident) throws NoSuchViewException {
+ if (null != asViewCatalog) {
+ try {
+ org.apache.iceberg.view.View view =
asViewCatalog.loadView(buildIdentifier(ident));
+ return new SparkView(catalogName, view);
+ } catch (org.apache.iceberg.exceptions.NoSuchViewException e) {
+ throw new NoSuchViewException(ident);
+ }
+ }
+
+ throw new NoSuchViewException(ident);
+ }
+
+ @Override
+ public View createView(
Review Comment:
ok I've replaced all methods to throw an UOE that aren't exercised by the
tests in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
