cccs-jc commented on code in PR #8980: URL: https://github.com/apache/iceberg/pull/8980#discussion_r1435311105
########## core/src/main/java/org/apache/iceberg/MicroBatches.java: ########## @@ -92,7 +92,7 @@ private static List<Pair<ManifestFile, Integer>> indexManifests( for (ManifestFile manifest : manifestFiles) { manifestIndexes.add(Pair.of(manifest, currentFileIndex)); - currentFileIndex += manifest.addedFilesCount() + manifest.existingFilesCount(); + currentFileIndex += manifest.addedFilesCount(); Review Comment: Exactly, see here I show how the existingFilesCount is only set when doing rewrites. https://github.com/apache/iceberg/pull/8980#issuecomment-1853964957 However the micro-batch streaming reader skips over rewrites. So it will never happen that the existingFilesCount is set in the above code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org