Fokko commented on code in PR #8980:
URL: https://github.com/apache/iceberg/pull/8980#discussion_r1435350938


##########
core/src/main/java/org/apache/iceberg/MicroBatches.java:
##########
@@ -92,7 +92,7 @@ private static List<Pair<ManifestFile, Integer>> 
indexManifests(
 
     for (ManifestFile manifest : manifestFiles) {
       manifestIndexes.add(Pair.of(manifest, currentFileIndex));
-      currentFileIndex += manifest.addedFilesCount() + 
manifest.existingFilesCount();
+      currentFileIndex += manifest.addedFilesCount();

Review Comment:
   It can happen, for example, it is easy to reproduce in 
`TestTransaction::testTransactionRecommit` where a new datafile is committed, 
and merged into an existing one:
   
   <img width="542" alt="image" 
src="https://github.com/apache/iceberg/assets/1134248/3cab9928-41c0-4fdc-b7b8-420f66ad906a";>
   
   Now, I'm questioning `skipManifests`, if it is valid to rely on the counts 
of manifests. But I have to dig deeper into this code since I'm not too 
familiar with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to