chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535457
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -118,45 +117,45 @@ public TestRewritePositionDeleteFilesAction(
this.format = format;
Review Comment:
I don't think that would be right.
The constructor is not only setting `format`, it also calls its parent's
constructor which is calling TestBaseWithCatalog's constructor, which is
starting the spark session and running sql queries.
When constructors are only setting the `@Parameter` values, I have removed
the constructor. See my changes in `TestRewriteManifestsAction`.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -938,8 +946,8 @@ public void testRemoveOrphanFilesWithStatisticFiles()
throws Exception {
.olderThan(System.currentTimeMillis() + 1000)
.execute();
- Assertions.assertThat(statsLocation.exists()).as("stats file should
exist").isTrue();
- Assertions.assertThat(statsLocation.length())
+ assertThat(statsLocation.exists()).as("stats file should exist").isTrue();
Review Comment:
ok!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
