chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -117,47 +119,46 @@ public static Object[][] parameters() {
"parquet-enabled", "true",
"cache-enabled",
"false" // Spark will delete tables using v1, leaving the
cache out of sync
- )
+ ),
+ "hadoop"
},
new Object[] {
"testhive",
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hive",
- "default-namespace", "default")
+ "default-namespace", "default"),
+ "hive"
},
new Object[] {
"testhadoop",
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hadoop",
- "default-namespace", "default")
+ "default-namespace", "default"),
+ "hadoop"
}
};
}
- @Rule public TemporaryFolder temp = new TemporaryFolder();
-
private String baseTableName = "baseTable";
private File tableDir;
private String tableLocation;
- private final String type;
- private final TableCatalog catalog;
- public TestCreateActions(String catalogName, String implementation,
Map<String, String> config) {
- super(catalogName, implementation, config);
- this.catalog = (TableCatalog)
spark.sessionState().catalogManager().catalog(catalogName);
- this.type = config.get("type");
- }
+ @Parameter(index = 3)
+ private String type;
- @Before
- public void before() {
+ private TableCatalog catalog;
+
+ @BeforeEach
+ public void beforeEach() {
Review Comment:
@nastra In your implementation, the constructor in the base class goes under
the before() with `@BeforeEach`.
But `@BeforeEach` overrides functions in the subclass which have the same
decorator and signature.
So, when I run tests in `TestCreateActions`, the base class before() doesnt
run & the environment is not setup.
For now, I've changed the function name to beforeEach() to highlight the
behaviour, but I don't know how to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
