nastra commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1436379721
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -117,47 +119,48 @@ public static Object[][] parameters() {
"parquet-enabled", "true",
"cache-enabled",
"false" // Spark will delete tables using v1, leaving the
cache out of sync
- )
+ ),
+ "hadoop"
},
new Object[] {
"testhive",
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hive",
- "default-namespace", "default")
+ "default-namespace", "default"),
+ "hive"
},
new Object[] {
"testhadoop",
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hadoop",
- "default-namespace", "default")
+ "default-namespace", "default"),
+ "hadoop"
Review Comment:
why is this additional parameter needed everywhere?
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -117,47 +119,48 @@ public static Object[][] parameters() {
"parquet-enabled", "true",
"cache-enabled",
"false" // Spark will delete tables using v1, leaving the
cache out of sync
- )
+ ),
+ "hadoop"
},
new Object[] {
"testhive",
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hive",
- "default-namespace", "default")
+ "default-namespace", "default"),
+ "hive"
},
new Object[] {
"testhadoop",
SparkCatalog.class.getName(),
ImmutableMap.of(
"type", "hadoop",
- "default-namespace", "default")
+ "default-namespace", "default"),
+ "hadoop"
Review Comment:
why is this additional parameter needed everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
