nastra commented on code in PR #9380:
URL: https://github.com/apache/iceberg/pull/9380#discussion_r1445301963
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestPositionDeletesTable.java:
##########
@@ -1278,10 +1321,10 @@ public void testNormalWritesNotAllowed() throws
IOException {
Dataset<Row> scanDF =
spark.read().format("iceberg").load(posDeletesTableName);
- Assert.assertThrows(
- "position_deletes table can only be written by RewriteDeleteFiles",
- IllegalArgumentException.class,
- () -> scanDF.writeTo(posDeletesTableName).append());
+ assertThatThrownBy(
+ () -> scanDF.writeTo(posDeletesTableName).append(),
+ "position_deletes table can only be written by RewriteDeleteFiles")
Review Comment:
I don't think we need this description. It should be self-explanatory that
this isn't supported once we add a exception message check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
