chinmay-bhat commented on code in PR #9380:
URL: https://github.com/apache/iceberg/pull/9380#discussion_r1446465432
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestPartitionValues.java:
##########
@@ -161,17 +162,17 @@ public void testNullPartitionValue() throws Exception {
List<SimpleRecord> actual =
result.orderBy("id").as(Encoders.bean(SimpleRecord.class)).collectAsList();
- Assert.assertEquals("Number of rows should match", expected.size(),
actual.size());
- Assert.assertEquals("Result rows should match", expected, actual);
+ assertThat(actual).as("Number of rows should
match").hasSameSizeAs(expected);
+ assertThat(actual).as("Result rows should match").isEqualTo(expected);
}
- @Test
+ @TestTemplate
public void testReorderedColumns() throws Exception {
String desc = "reorder_columns";
- File parent = temp.newFolder(desc);
+ File parent = new File(temp.toFile(), desc);
Review Comment:
https://github.com/apache/iceberg/pull/9380#discussion_r1446433055
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReadProjection.java:
##########
@@ -110,10 +110,10 @@ public static void stopSpark() {
@Override
protected Record writeAndRead(String desc, Schema writeSchema, Schema
readSchema, Record record)
throws IOException {
- File parent = temp.newFolder(desc);
+ File parent = new File(temp.toFile(), desc);
Review Comment:
https://github.com/apache/iceberg/pull/9380#discussion_r1446433055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
