rdblue commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1462320114
########## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcUtil.java: ########## @@ -18,6 +18,22 @@ */ package org.apache.iceberg.jdbc; +import static org.apache.iceberg.jdbc.JdbcUtil.createCatalogTableSql; +import static org.apache.iceberg.jdbc.JdbcUtil.createCatalogViewSql; +import static org.apache.iceberg.jdbc.JdbcUtil.dropTableSql; +import static org.apache.iceberg.jdbc.JdbcUtil.dropViewSql; +import static org.apache.iceberg.jdbc.JdbcUtil.filterAndRemovePrefix; +import static org.apache.iceberg.jdbc.JdbcUtil.getTableSql; +import static org.apache.iceberg.jdbc.JdbcUtil.getViewSql; +import static org.apache.iceberg.jdbc.JdbcUtil.listTableNamespacesSql; +import static org.apache.iceberg.jdbc.JdbcUtil.listTablesSql; +import static org.apache.iceberg.jdbc.JdbcUtil.listViewNamespacesSql; +import static org.apache.iceberg.jdbc.JdbcUtil.listViewsSql; +import static org.apache.iceberg.jdbc.JdbcUtil.renameTableSql; +import static org.apache.iceberg.jdbc.JdbcUtil.renameViewSql; +import static org.apache.iceberg.jdbc.JdbcUtil.tableNamespaceSql; +import static org.apache.iceberg.jdbc.JdbcUtil.viewNamespaceSql; Review Comment: The project prefers not to use static imports so that you can clearly see where methods are defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
