jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1462793255
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -245,13 +270,17 @@ public List<TableIdentifier> listTables(Namespace
namespace) {
row ->
JdbcUtil.stringToTableIdentifier(
row.getString(JdbcUtil.TABLE_NAMESPACE),
row.getString(JdbcUtil.TABLE_NAME)),
- JdbcUtil.LIST_TABLES_SQL,
+ JdbcUtil.listTablesSql(),
catalogName,
JdbcUtil.namespaceToString(namespace));
}
@Override
public void renameTable(TableIdentifier from, TableIdentifier to) {
+ if (viewExists(to)) {
+ throw new AlreadyExistsException("Cannot rename %s to %s. View already
exists", from, to);
Review Comment:
@amogh-jahagirdar I'm using the expected exception message to have the tests
happy 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
