nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1462869217
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -303,7 +287,294 @@ public static Properties
filterAndRemovePrefix(Map<String, String> properties, S
return result;
}
- public static String updatePropertiesStatement(int size) {
+ static String getSql(boolean isTable) {
+ String tableName = isTable ? CATALOG_TABLE_NAME : CATALOG_VIEW_NAME;
+ String namespace = isTable ? TABLE_NAMESPACE : VIEW_NAMESPACE;
+ String name = isTable ? TABLE_NAME : VIEW_NAME;
+ return String.format(GET, tableName, namespace, name);
+ }
+
+ static String getTableSql() {
Review Comment:
this one still has a `get` prefix. Maybe rename this to `tableSql()` or
`sqlForTable()`, but the former probably better aligns with the other method
naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
