HonahX commented on code in PR #288:
URL: https://github.com/apache/iceberg-python/pull/288#discussion_r1464342275
##########
tests/catalog/integration_test_glue.py:
##########
@@ -279,6 +379,20 @@ def test_commit_table_update_schema(
assert test_catalog._parse_metadata_version(table.metadata_location) == 0
assert original_table_metadata.current_schema_id == 0
+ assert athena.get_query_results(f'SELECT * FROM
"{database_name}"."{table_name}"') == [
Review Comment:
> In other words, if the table was created and not queryable, then a table
was not actually successfully created.
I hadn't considered this perspective initially. But indeed, these are very
sound reasoning! Let's maintain the current state of these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
