HonahX commented on code in PR #288:
URL: https://github.com/apache/iceberg-python/pull/288#discussion_r1464346417
##########
pyiceberg/catalog/glue.py:
##########
@@ -84,17 +110,97 @@ def _construct_parameters(
return new_parameters
+GLUE_PRIMITIVE_TYPES = {
+ BooleanType: "boolean",
+ IntegerType: "int",
+ LongType: "bigint",
+ FloatType: "float",
+ DoubleType: "double",
+ DateType: "date",
+ TimeType: "string",
+ StringType: "string",
+ UUIDType: "string",
+ TimestampType: "timestamp",
+ FixedType: "binary",
+ BinaryType: "binary",
+}
+
+
+class IcebergSchemaToGlueType(SchemaVisitor[str]):
+ def schema(self, schema: Schema, struct_result: str) -> str:
+ return struct_result
+
+ def struct(self, struct: StructType, field_results: List[str]) -> str:
+ return f"struct<{','.join(field_results)}>"
+
+ def field(self, field: NestedField, field_result: str) -> str:
+ return f"{field.name}:{field_result}"
+
+ def list(self, list_type: ListType, element_result: str) -> str:
+ return f"array<{element_result}>"
+
+ def map(self, map_type: MapType, key_result: str, value_result: str) ->
str:
+ return f"map<{key_result},{value_result}>"
+
+ def primitive(self, primitive: PrimitiveType) -> str:
+ if isinstance(primitive, DecimalType):
+ return f"decimal({primitive.precision},{primitive.scale})"
+ if (primitive_type := type(primitive)) not in GLUE_PRIMITIVE_TYPES:
+ raise ValueError(f"Unknown primitive type: {primitive}")
+ return GLUE_PRIMITIVE_TYPES[primitive_type]
+
+
+def _to_columns(metadata: TableMetadata) -> List[ColumnTypeDef]:
+ results: Dict[str, ColumnTypeDef] = {}
+
+ def _append_to_results(field: NestedField, is_current: bool) -> None:
+ if field.name in results:
+ return
+
+ results[field.name] = cast(
+ ColumnTypeDef,
+ {
+ "Name": field.name,
+ "Type": visit(field.field_type, IcebergSchemaToGlueType()),
Review Comment:
```suggestion
"Type": visit(field.field_type, _IcebergSchemaToGlueType()),
```
##########
pyiceberg/catalog/glue.py:
##########
@@ -84,17 +110,97 @@ def _construct_parameters(
return new_parameters
+GLUE_PRIMITIVE_TYPES = {
+ BooleanType: "boolean",
+ IntegerType: "int",
+ LongType: "bigint",
+ FloatType: "float",
+ DoubleType: "double",
+ DateType: "date",
+ TimeType: "string",
+ StringType: "string",
+ UUIDType: "string",
+ TimestampType: "timestamp",
+ FixedType: "binary",
+ BinaryType: "binary",
+}
+
+
+class IcebergSchemaToGlueType(SchemaVisitor[str]):
Review Comment:
```suggestion
class _IcebergSchemaToGlueType(SchemaVisitor[str]):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
