rdblue commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465562137
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -350,39 +350,21 @@ public void readFromViewReferencingAnotherView() throws
NoSuchTableException {
}
@Test
- public void readFromViewReferencingTempView() throws NoSuchTableException {
Review Comment:
I think the original version of this test is still valid. We want to fail if
the view references a temp view because the temp view will not be resolved. The
fact that we can't create a view that references a temp view in SQL is a
separate consideration to test.
This is a good demonstration of why it's good to test with both SQL view
creation and API view creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
