nastra commented on code in PR #9423:
URL: https://github.com/apache/iceberg/pull/9423#discussion_r1465986604


##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -350,39 +350,21 @@ public void readFromViewReferencingAnotherView() throws 
NoSuchTableException {
   }
 
   @Test
-  public void readFromViewReferencingTempView() throws NoSuchTableException {

Review Comment:
   yeah I wasn't sure exactly how we'd want to handle these cases. I agree that 
those are separate concerns, because in one case it should fail when the view 
is being created and in the other case it should fail when the view is being 
read from. I'll add a separate test case for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to