ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470662411
##########
crates/iceberg/src/io.rs:
##########
@@ -268,6 +268,16 @@ impl OutputFile {
.await?)
}
+ /// Delete file.
+ pub async fn delete(&self) -> Result<()> {
Review Comment:
> I'm thinking of the bad cases: If the delete returns error, how can we
retry this operation?
This delete operation used in the cases:
The writer created and it didn't write anything, so we deleted it to avoid
the empty file. If delete fails here, can we just skip this rare case?🤔
But I find that there maybe a wrong hypothesis. Does [writer in
opendal](https://docs.rs/opendal/latest/opendal/struct.Operator.html?search=writer#method.writer)
create the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
