ZENOTME commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1470672780
##########
crates/iceberg/src/io.rs:
##########
@@ -278,7 +288,7 @@ impl OutputFile {
}
/// Creates output file for writing.
- pub async fn writer(&self) -> Result<impl FileWrite> {
+ pub async fn writer(&self) -> Result<Writer> {
Ok(self.op.writer(&self.path[self.relative_path_pos..]).await?)
Review Comment:
> There is another thing we can do is adding concurrent here so we can
upload parts concurrently. But we need to make a design on how users control
the concurrency. Maybe we can discuss them later.
Yes, we can open a discussion about it. IMO, the concurrent writer is used
in the case that writes multiple files concurrently. So concurrent writer may
should be a higher-level writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
