danielcweeks commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475376446
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java:
##########
@@ -71,7 +68,7 @@ public void doRefresh() {
Map<String, String> table;
try {
- table = getTable();
+ table = JdbcUtil.tableOrView(true, connections, catalogName,
tableIdentifier);
Review Comment:
Now I'm seeing what this is doing. I think we need to update this method as
it's rather confusing that the first param is toggling between loading a table
and a view. We should either split it to to be `loadTable` and `loadView` or
have something more explicit (like an enum) for the type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
