danielcweeks commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475391895
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -245,13 +286,18 @@ public List<TableIdentifier> listTables(Namespace
namespace) {
row ->
JdbcUtil.stringToTableIdentifier(
row.getString(JdbcUtil.TABLE_NAMESPACE),
row.getString(JdbcUtil.TABLE_NAME)),
- JdbcUtil.LIST_TABLES_SQL,
+ JdbcUtil.LIST_TABLE_SQL,
catalogName,
- JdbcUtil.namespaceToString(namespace));
+ JdbcUtil.namespaceToString(namespace),
+ "TABLE");
}
@Override
public void renameTable(TableIdentifier from, TableIdentifier to) {
+ if (viewExists(to)) {
Review Comment:
Similar to the view rename, we should either be preemptively checking for
both or neither to be consistent. This isn't an atomic check anyway, so the
real check is being handled by the database constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
