nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489559055
##########
core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java:
##########
@@ -101,16 +101,20 @@ public void readAndWriteValidViewMetadata() throws
Exception {
String json =
readViewMetadataInputFile("org/apache/iceberg/view/ValidViewMetadata.json");
ViewMetadata expectedViewMetadata =
- ViewMetadata.builder()
- .assignUUID("fa6506c3-7681-40c8-86dc-e36561f83385")
- .addSchema(TEST_SCHEMA)
- .addVersion(version1)
- .addVersion(version2)
- .setLocation("s3://bucket/test/location")
- .setProperties(
- ImmutableMap.of("some-key", "some-value",
ViewProperties.COMMENT, "some-comment"))
+ ViewMetadata.buildFrom(
Review Comment:
this (and the other places) is just wrapping it in a
`ViewMetadata.buildFrom(..).setCurrentVersionId(2).build()` call, because
`ValidViewMetadata.json` expects 2 versions in the `version-log`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
