nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490598286
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -504,6 +517,11 @@ static List<ViewHistoryEntry>
updateHistory(List<ViewHistoryEntry> history, Set<
}
}
+ // keep the last numVersionsToKeep in the history
Review Comment:
For some reason I thought `version.history.num-entries` applies to both
`versions` and `history` due to having `history` in its name. In hindsight this
was a wrong assumption, so I've rolled back those changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
