amogh-jahagirdar commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1491185660
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -504,6 +517,11 @@ static List<ViewHistoryEntry>
updateHistory(List<ViewHistoryEntry> history, Set<
}
}
+ // keep the last numVersionsToKeep in the history
Review Comment:
I'm a bit confused, I get that history and versions are independent from
each other but here we want `version.history.num-entries` to apply to history
no? Or is it just bad naming of the property and it should apply to versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
