rdblue commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r444578776
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java
##########
@@ -396,7 +409,12 @@ private FixedReader(ColumnDescriptor desc) {
}
}
- static class RecordReader extends StructReader<Record, Record> {
+ public interface StructReaderFactory<T> {
+
+ StructReader<T, T> create(List<Type> types, List<ParquetValueReader<?>>
readers, StructType struct);
+ }
+
+ static class RecordReader extends StructReader<GenericRecord, GenericRecord>
{
Review comment:
Why change this to use the `GenericRecord` instance rather than the
`Record` interface?
I don't see much value in this change. We will just need to change it back
if we want to add implementations of `Record` that are not generic, like we do
with our internal classes that extend Avro's `IndexedRecord`. Ideally, I'd like
to change those over to internal records eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
