rdblue commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r444579389
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java
##########
@@ -396,7 +409,12 @@ private FixedReader(ColumnDescriptor desc) {
}
}
- static class RecordReader extends StructReader<Record, Record> {
+ public interface StructReaderFactory<T> {
Review comment:
Similar to the write path, I think it would be nice to refactor this to
avoid exposing new public methods and interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
