rdblue commented on pull request #1125: URL: https://github.com/apache/iceberg/pull/1125#issuecomment-650295324
@openinx, I think this is ready to commit other than the public interfaces and methods to pass struct factories. I'd like to make those protected or go with the inheritance approach. Personally, I think the inheritance approach is cleaner and I don't mind the method you pointed out, but either way I think can work. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
