openinx commented on pull request #1125: URL: https://github.com/apache/iceberg/pull/1125#issuecomment-652771218
@rdblue , Seems it's more clearer to abstract the generic logics in a separate `BaseParquetReader<T>` and make the `RecordParquetReader` to extend it. I implemented this in https://github.com/apache/iceberg/pull/1158, you may want to take a look. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
