RussellSpitzer commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1506165907
##########
core/src/main/java/org/apache/iceberg/encryption/AesGcmOutputStream.java:
##########
@@ -158,4 +163,17 @@ private void encryptAndWriteBlock() throws IOException {
positionInPlainBlock = 0;
currentBlockIndex++;
}
+
+ public static long gcmEncryptionLength(long plainLength) {
Review Comment:
Do we really have to do this math? Can't we just check the bytes written?
Haven't looked at the underlying code here so I could be lost. Just seems weird
that we have to recalculate this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
