ggershinsky commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1506255579
##########
core/src/main/java/org/apache/iceberg/encryption/AesGcmOutputStream.java:
##########
@@ -129,6 +129,11 @@ public void close() throws IOException {
targetStream.close();
}
+ @Override
+ public long storedLength() throws IOException {
+ return targetStream.storedLength();
Review Comment:
this works. But to be on the safe side, might have to be replaced with
`targetStream.getPos()`. If the target stream is not length preserving (for
some strange reason), then the AES GCM Stream decryption will be broken by this
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
