rdblue commented on a change in pull request #1153:
URL: https://github.com/apache/iceberg/pull/1153#discussion_r449235477
##########
File path: core/src/main/java/org/apache/iceberg/data/avro/DataWriter.java
##########
@@ -50,13 +50,17 @@ public void setSchema(Schema schema) {
this.writer = (ValueWriter<T>) AvroSchemaVisitor.visit(schema, new
WriteBuilder());
}
+ protected void setWriter(ValueWriter<T> writer) {
+ this.writer = writer;
Review comment:
Should `setWriter` be used in `setSchema` above for this class as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
