rdblue commented on a change in pull request #1153:
URL: https://github.com/apache/iceberg/pull/1153#discussion_r449236225
##########
File path: core/src/main/java/org/apache/iceberg/data/avro/DataWriter.java
##########
@@ -50,13 +50,17 @@ public void setSchema(Schema schema) {
this.writer = (ValueWriter<T>) AvroSchemaVisitor.visit(schema, new
WriteBuilder());
}
+ protected void setWriter(ValueWriter<T> writer) {
+ this.writer = writer;
+ }
+
@Override
public void write(T datum, Encoder out) throws IOException {
writer.write(datum, out);
}
- private static class WriteBuilder extends AvroSchemaVisitor<ValueWriter<?>> {
- private WriteBuilder() {
+ protected static class WriteBuilder extends
AvroSchemaVisitor<ValueWriter<?>> {
+ protected WriteBuilder() {
Review comment:
Can we remove the constructor since it is empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
