ZENOTME opened a new issue, #260: URL: https://github.com/apache/iceberg-rust/issues/260
For FileWriter close fail, it may result in a garbage file. I look through how java process it, and seems it provided a interface like `abort` so user can call abort if it close fail. But our writer will consume the writer in `fn close(self)` which means that we can't access it later. So there are three solutions: 1. Clean them automatically. 2. Return them in error. But then all error return by writer should contains this message. I think it's not a good way. 3. Can we modify the interface to `fn close(&mut self)`.🤔 But it may make the implementation be more complicate. E.g. we need to keep track the state in writer. My concern of first solution is that is this what user expect? cc @liurenjie1024 @Xuanwo @Fokko @JanKaul -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
