Xuanwo commented on issue #260: URL: https://github.com/apache/iceberg-rust/issues/260#issuecomment-1994292504
> For FileWriter close fail, it may result in a garbage file. I assume that `FileWriter` just about writing a single file. For most object storage services (like s3, gcs and azblob), it should be fine: - Files via `PutObject` doesn't exist while failed. - Files via `Multipart` doesn't exist while failed and incomplete muiltpart is easy to cleanup For file based services (like fs, hdfs), it should also be fine if users enabled opendal's `atomic_write_dir` feature which makes sure that file only been visible after `close` returning success. > 3. Can we modify the interface to `fn close(&mut self)` OpenDAL follows this pattern to allow users to abort writing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
