dramaticlly commented on code in PR #9813:
URL: https://github.com/apache/iceberg/pull/9813#discussion_r1538335617
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -158,14 +176,26 @@ static class ManifestReadTask extends BaseFileScanTask
implements DataTask {
@Override
public CloseableIterable<StructLike> rows() {
Types.NestedField readableMetricsField =
projection.findField(MetricsUtil.READABLE_METRICS);
+ Types.NestedField dataSequenceNumberField =
+ projection.findField(MetadataTableUtils.DATA_SEQUENCE_NUMBER);
- if (readableMetricsField == null) {
+ if (readableMetricsField == null && dataSequenceNumberField == null) {
Review Comment:
Now rows() method is very light and projection of computed columns moved
inside the constructor of new StructLike
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
