dramaticlly commented on code in PR #9813:
URL: https://github.com/apache/iceberg/pull/9813#discussion_r1538338541
##########
core/src/main/java/org/apache/iceberg/MetadataTableUtils.java:
##########
@@ -109,4 +117,68 @@ public static Table createMetadataTableInstance(
private static String metadataTableName(String tableName, MetadataTableType
type) {
return tableName + (tableName.contains("/") ? "#" : ".") +
type.name().toLowerCase(Locale.ROOT);
}
+
+ static class StructWithDerivedColumns implements StructLike {
Review Comment:
Discussed with @szehon-ho offline and adopted index based projection map
similar to StructProjection. However I realized there's [some logic in
BaseFile](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/BaseFile.java#L106-L120)
are really similar to what we want. However there's some thing I dont quite
get for partitionData projection when when one of the partition column get
dropped as part of partition evolution. So far I am leave the change as is for
BaseFiles. If everything looks right to you, I will adopt the computed columns
change for BaseEntries files as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
