nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1549450840
##########
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##########
@@ -108,11 +112,8 @@ public void writeTestDataFile() throws IOException {
records.add(record.copy("id", 122, "data", "g"));
this.dataFile =
- FileHelpers.writeDataFile(
- table,
- Files.localOutput(File.createTempFile("junit", null,
temp.toFile())),
- Row.of(0),
- records);
+ FileHelpers.writeDataFile(table, Files.localOutput(temp), Row.of(0),
records);
Review Comment:
please revert all changes to `DeleteReadTest`. Tests need a new temp file
and your changes aren't providing that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
