nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1555319681
##########
data/src/test/java/org/apache/iceberg/RecordWrapperTest.java:
##########
@@ -103,11 +103,11 @@ public void testNestedSchema() {
}
private void generateAndValidate(Schema schema) {
- generateAndValidate(schema, Assert::assertEquals);
+ generateAndValidate(schema, Assertions::assertThat);
}
public interface AssertMethod {
- void assertEquals(String message, StructLikeWrapper expected,
StructLikeWrapper actual);
+ void assertThat(StructLikeWrapper actual);
Review Comment:
I don't think we should be renaming this. This isn't related to JUnit4 ->
JUnit5 migration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
