rdblue commented on a change in pull request #1158:
URL: https://github.com/apache/iceberg/pull/1158#discussion_r453131014
##########
File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcReader.java
##########
@@ -53,86 +50,13 @@ public GenericOrcReader(
@Override
public Record read(VectorizedRowBatch batch, int row) {
- return (Record) reader.read(new StructColumnVector(batch.size,
batch.cols), row);
+ return (Record) getReader().read(new StructColumnVector(batch.size,
batch.cols), row);
Review comment:
Getter methods should not start with `get`. It doesn't add anything
(every method "gets" its return value) and is not idiomatic in other JVM
languages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
