openinx commented on a change in pull request #1158: URL: https://github.com/apache/iceberg/pull/1158#discussion_r453547032
########## File path: data/src/main/java/org/apache/iceberg/data/orc/BaseOrcReader.java ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.data.orc; + +import java.util.List; +import java.util.Map; +import org.apache.iceberg.orc.OrcRowReader; +import org.apache.iceberg.orc.OrcSchemaWithTypeVisitor; +import org.apache.iceberg.orc.OrcValueReader; +import org.apache.iceberg.orc.OrcValueReaders; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; +import org.apache.orc.TypeDescription; + +public abstract class BaseOrcReader<T> implements OrcRowReader<T> { Review comment: I agreed that extending the `BaseOrcReader` and `BaseOrcWriter` introduces tight coupling, I tried to de-couple `flink` writer from generic orc writers and let them share the common writers. But seems it's hard to share the codes because we used a static `buildConverter` method to build the converter for each data type and few Converter depends on the static `buildConverter`, makes hard to abstract to the common converters. Just curious why did we implement the orc writer in `converter` way instead of visiting the types by `OrcSchemaWithTypeVisitor` and generate relative `OrcRowWriter` (in this way we could share most of the writers.), the current `converter` seems strange compared to other `parquet` writers and `avro` writers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
