aokolnychyi commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1577030981
########## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java: ########## @@ -56,7 +58,8 @@ abstract class BaseDeltaTaskWriter extends BaseTaskWriter<RowData> { Schema schema, RowType flinkSchema, List<Integer> equalityFieldIds, - boolean upsert) { + boolean upsert, + DeleteGranularity deleteGranularity) { Review Comment: Is there a use case where we want to use partition granularity? Based on our initial discussions, we wanted to always use file granularity in Flink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org