pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1579259488
########## core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java: ########## @@ -174,20 +208,21 @@ private void flushDeletes() { } catch (IOException e) { setFailure(e); throw new UncheckedIOException( - "Failed to write the sorted path/pos pairs to pos-delete file: " - + outputFile.encryptingOutputFile().location(), Review Comment: reverted ########## core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java: ########## @@ -59,20 +60,58 @@ class SortedPosDeleteWriter<T> implements FileWriter<PositionDelete<T>, DeleteWr OutputFileFactory fileFactory, FileFormat format, StructLike partition, - long recordsNumThreshold) { + long recordsNumThreshold, + DeleteGranularity deleteGranularity) { this.appenderFactory = appenderFactory; this.fileFactory = fileFactory; this.format = format; this.partition = partition; this.recordsNumThreshold = recordsNumThreshold; + this.deleteGranularity = deleteGranularity; + } + + SortedPosDeleteWriter( Review Comment: reverted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org