aokolnychyi commented on code in PR #10200:
URL: https://github.com/apache/iceberg/pull/10200#discussion_r1580294047
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -56,7 +58,8 @@ abstract class BaseDeltaTaskWriter extends
BaseTaskWriter<RowData> {
Schema schema,
RowType flinkSchema,
List<Integer> equalityFieldIds,
- boolean upsert) {
+ boolean upsert,
+ DeleteGranularity deleteGranularity) {
Review Comment:
Are we worried about the increased metadata size? If so, I don't think it
should be a problem as position delete files require much less metadata and
highly doubt the difference will be noticed.
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java:
##########
@@ -56,7 +58,8 @@ abstract class BaseDeltaTaskWriter extends
BaseTaskWriter<RowData> {
Schema schema,
RowType flinkSchema,
List<Integer> equalityFieldIds,
- boolean upsert) {
+ boolean upsert,
+ DeleteGranularity deleteGranularity) {
Review Comment:
Are we worried about the increased metadata size? If so, I don't think it
should be a problem as position delete files require much less metadata and I
highly doubt the difference will be noticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
