rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581590662
########## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ########## @@ -278,14 +286,26 @@ public void setConf(Object newConf) { @Override public List<TableIdentifier> listTables(SessionContext context, Namespace ns) { checkNamespaceIsValid(ns); + Map<String, String> queryParams = Maps.newHashMap(); + List<TableIdentifier> tables = Lists.newArrayList(); Review Comment: Actually when using `ImmutableList` I get the following exception, so not sure if this is ideal ``` RESTSessionCatalog.java:305: error: [DoNotCall] This method should not be called: Always throws UnsupportedOperationException tables.addAll(response.identifiers()); ^ (see https://errorprone.info/bugpattern/DoNotCall) ``` I see that in other areas in the `RESTSessionCatalog` that we do initialize `List` like so, so I think keeping this line should be fine, unless you see some concerns with this? ``` private final List<ViewRepresentation> representations = Lists.newArrayList(); List<UpdateTableRequest> tableChanges = Lists.newArrayListWithCapacity(commits.size()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org