danielcweeks commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1581860457
########## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ########## @@ -136,6 +137,7 @@ public class RESTSessionCatalog extends BaseViewSessionCatalog private FileIO io = null; private MetricsReporter reporter = null; private boolean reportingViaRestEnabled; + private String restPageSize = null; Review Comment: We should make this `Integer` not `String` ########## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ########## @@ -278,14 +286,26 @@ public void setConf(Object newConf) { @Override public List<TableIdentifier> listTables(SessionContext context, Namespace ns) { checkNamespaceIsValid(ns); + Map<String, String> queryParams = Maps.newHashMap(); + List<TableIdentifier> tables = Lists.newArrayList(); Review Comment: I think he was recommending something like: ```java ImmutableList.Builder<TableIdentifier> result = ImmutableList.<TableIdentifier>builder(); return result.build(); ``` ########## core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java: ########## @@ -228,6 +230,13 @@ public void initialize(String name, Map<String, String> unresolved) { client, tokenRefreshExecutor(), token, expiresAtMillis(mergedProps), catalogAuth); } + this.restPageSize = mergedProps.get(REST_PAGE_SIZE); Review Comment: Looking at where we ended up here, I think it make smore sense now to use: ```java import org.apache.iceberg.util.PropertyUtil; this.restPageSize =PropertyUtil.propertyAsNullableInt(mergedProps, REST_PAGE_SIZE); ``` This avoids needing to do the parsing and lets the property util class expose the parse error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org